On Mon, 2011-02-28 at 10:33 +0200, Felipe Balbi wrote: 
> On Sun, Feb 27, 2011 at 12:34:33AM +0100, Michael Buesch wrote:
> > The mutex has to be acquired on register write to avoid interference
> > with a simultaneous retu_set_clear_reg_bits operation.
> > 
> > Signed-off-by: Michael Buesch <[email protected]>
> 
> good catch, please do the same for retu_read_reg()

I don't think this is necessary, because cbus_read_reg() and
cbus_write_reg() are atomic due to the cbus host->lock.
I think we can depend on this.
We could probably improve the comment on the lock in
cbus_transfer(), though.

-- 
Greetings Michael.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to