On Mon, 2011-02-28 at 09:02 -0600, Semwal, Sumit wrote: > Provide a function in pdata to allow dss submodules to check if a given > clock is available on a platform as an optional clock. > > Signed-off-by: Senthilvadivu Guruswamy <[email protected]> > (based on implementation from Senthil) > > Signed-off-by: Sumit Semwal <[email protected]> > --- > arch/arm/mach-omap2/display.c | 20 ++++++++++++++++++++ > arch/arm/plat-omap/include/plat/display.h | 2 ++ > 2 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c > index 5ab6a74..9f4f862 100644 > --- a/arch/arm/mach-omap2/display.c > +++ b/arch/arm/mach-omap2/display.c > @@ -42,6 +42,25 @@ static struct omap_device_pm_latency omap_dss_latency[] = { > }, > }; > > +static bool opt_clock_available(const char *clk_role) > +{ > + int i; > + struct omap_hwmod *oh; > + > + /* opt_clks are always associated with dss hwmod */ > + oh = omap_hwmod_lookup("dss_core"); > + if (!oh) { > + pr_err("Could not look up dss_core.\n"); > + return -ENODEV;
The function returns a bool. Perhaps the lookup would be better done in omap_display_init(), and stored in a static variable. Or if it's clear that this should never happen, BUG_ON(!oh); Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
