"Menon, Nishanth" <[email protected]> writes: > On Wed, Feb 16, 2011 at 11:48, Shweta Gulati <[email protected]> wrote: >> All OMAP4 boards support OPP-Turbo (800M) and OPP-Nitro (1G). > s/All OMAP4/Almost all/ - there are a minority of boards that use > OMAP4430-800 device instead of the OMAP4430-1000 device. > Also please use the full term 1GHz instead of 1G >> Enable them by default in OPPTable. For 800Mhz devices where > s/For 800Mhz/For the small minority of boards which use OMAP4430-800 > (800MHz device), >> OPP-Nitro is not supported, OPP-Nitro should be disabled >> from board file. > > even though the TI documentation terminology is Turbo, Nitro etc.., I > suggest using frequencies to better map things historically.
I agree, IMO the Turbo & Nitro names are useless. Kevin >> >> Signed-off-by: Shweta Gulati <[email protected]> >> --- >> arch/arm/mach-omap2/opp4xxx_data.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c >> b/arch/arm/mach-omap2/opp4xxx_data.c >> index 705fe9a..48d79e5 100644 >> --- a/arch/arm/mach-omap2/opp4xxx_data.c >> +++ b/arch/arm/mach-omap2/opp4xxx_data.c >> @@ -31,9 +31,9 @@ static struct omap_opp_def __initdata >> omap44xx_opp_def_list[] = { >> /* MPU OPP2 - OPP100 */ >> OPP_INITIALIZER("mpu", true, 600000000, OMAP4430_VDD_MPU_OPP100_UV), >> /* MPU OPP3 - OPP-Turbo */ >> - OPP_INITIALIZER("mpu", false, 800000000, >> OMAP4430_VDD_MPU_OPPTURBO_UV), >> + OPP_INITIALIZER("mpu", true, 800000000, >> OMAP4430_VDD_MPU_OPPTURBO_UV), >> /* MPU OPP4 - OPP-SB */ >> - OPP_INITIALIZER("mpu", false, 1008000000, >> OMAP4430_VDD_MPU_OPPNITRO_UV), >> + OPP_INITIALIZER("mpu", true, 1008000000, >> OMAP4430_VDD_MPU_OPPNITRO_UV), >> /* L3 OPP1 - OPP50 */ >> OPP_INITIALIZER("l3_main_1", true, 100000000, >> OMAP4430_VDD_CORE_OPP50_UV), >> /* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */ >> -- >> 1.7.0.4 > > I am ok with the overall patch - with the minor suggestions above. > > Regards, > Nishanth Menon > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
