Nishanth Menon <[email protected]> writes: > We will enable and disable interrupt on a need basis in the class > driver. we need to keep the irq disabled by default else the > forceupdate or vcbypass events could trigger events that we dont > need/expect to handle.
It's not clear from the patch where the IRQ is re-enabled. For example, without knowing better, I would expect a corresponding change to the Class 3 driver to enable/disable the IRQ as needed. Kevin > Signed-off-by: Nishanth Menon <[email protected]> > --- > arch/arm/mach-omap2/smartreflex.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/smartreflex.c > b/arch/arm/mach-omap2/smartreflex.c > index 7931fcd..9c61ab0 100644 > --- a/arch/arm/mach-omap2/smartreflex.c > +++ b/arch/arm/mach-omap2/smartreflex.c > @@ -281,6 +281,7 @@ static int sr_late_init(struct omap_sr *sr_info) > IRQF_DISABLED, name, (void *)sr_info); > if (ret) > goto error; > + disable_irq(sr_info->irq); > } > > if (pdata && pdata->enable_on_init) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
