> -----Original Message-----
> From: Tony Lindgren [mailto:t...@atomide.com]
> Sent: Wednesday, March 02, 2011 11:34 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap2plus: Remove auto selection on PMICs
>
> * Premi, Sanjeev <pr...@ti.com> [110226 00:27]:
> > > -----Original Message-----
> > > From: Tony Lindgren [mailto:t...@atomide.com]
> > > Sent: Friday, February 25, 2011 11:47 PM
> > > To: Premi, Sanjeev
> > > Cc: linux-omap@vger.kernel.org
> > > Subject: Re: [PATCH] omap2plus: Remove auto selection on PMICs
> > >
> > > * Sanjeev Premi <pr...@ti.com> [110223 04:11]:
> > > > The current implementation almost assumes that only
> > > > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > > > OMAP processors. This is, however, not true.
> > >
> > > If selecting these on platforms that don't have twl
> > > causes problems the problem should be fixed.
> > >
> > > You can disable CONFIG_ARCH_OMAP2PLUS_TYPICAL, and
> > > then these don't get selected.
> >
> > [sp] But this means MUTLI_OMAP breaks. And same uImage
> > won't run on the AM3517 EVM.
> >
> > If I remember, the problem is caused due to twl specific
> > functions called even if it isn't present. And there is
> > implicit assumption on TWL in most of code.
>
> Then let's fix that problem instead. The TWL functions should
> not get called (or at least they should not do anything)
> unless the TWL chip is there.
[sp] Agree. Driver needs to be fixed. But, will take longer and
AM35x will continue to suffer. Will start on this...
>
> > [sp] I will be away from work for next week; may not
> > be able to try this; but don't you think dependency
> > on ARM is too generic? And this should still be fixed..
[sp] I haven't yet tried it myself. Need to clear lot of regular
backlog before I can try this later this week.
> >
> > - depends on TWL4030_CORE && ARM
> > + depends on TWL4030_CORE && (ARCH_OMAP3 || ARCH_OMAP4)
>
> Well in theory all the drivers should just build on whatever
> platform. I don't know if changing that really improves things,
> we should improve the driver instead.
>
> Note for example how the tps65010.c driver also builds on x86.
> That allows people doing Linux generic changes to build test
> those changes:
[sp] Agree. But TPS6510 is far more generic PMIC than TWL4030 or
others in the same family.
Going by the argument, we should then be removing processor
dependency altogether, i.e:
- depends on TWL4030_CORE && ARM
+ depends on TWL4030_CORE
>
> $git log --pretty=oneline drivers/mfd/tps65010.c
> 77b22897da093e80c40f03e8d83bf23e756b9fba mfd: Include <linux/gpio.h>
> instead of
> afdb32f2e463a195c104555ac9a8cdd39a2b6561 mfd: update workqueue usages
> fbae3fb1546e199ab0cd185348f8124411a1ca9d i2c: Remove all
> i2c_set_clientdata(clie
> f322d5f0097333343bfd92b47258ee997c889263 mfd: Fix dangling
> pointersRegards,
> ...
>
> So instead of breakage for the tps65010 driver we instead got
> the above changes compile tested as an extra bonus.
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
