On Mon, 2011-03-07 at 09:43 +0200, Felipe Balbi wrote: > > - struct miscdevice retu_wdt_miscdev; > > + struct miscdevice miscdev; > > this rename is not part of $SUBJECT
Well, that element is used in several new container_of() instances. retu_wdt_miscdev is needlessly long and just increases the line-length pain on the container_of() lines. The retu_wdt prefix is useless, because it's an element of the retu_wdt data structure. > > struct delayed_work ping_work; > > + struct mutex mutex; > > checkpatch.pl --strict will complain about this mutex not having a > comment explaining it. Can you add something ? Is that really required? I mean, it's obvious what the mutex is used for and what it is protecting (the whole struct). > > -static int _retu_modify_counter(unsigned int new) > > +static inline void _retu_modify_counter(struct retu_wdt_dev *wdev, > > + unsigned int new) > > let the compiler inline it, maybe ?!? Ok, it doesn't change the object code either way. -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
