Hi All, > Hello All, > > Any comments on this patch? > > Regards, > Keerthy > > On Wed, Mar 2, 2011 at 2:17 AM, Keerthy <j-keer...@ti.com> wrote: > > twl4030_wdt driver and omap_wdt driver are registering as misc_device name > > as > > "watchdog" and the same minor number WATCHDOG_MINOR( value = 130). > > There is a conflict since the name and minor were the same for > > both the misc_device registered by omap_wdt.c as well as twl4030_wdt.c > > > > The omap_wdt.c probe is getting called first. Hence it succeeds. > > twl4030_wdt.c always failed on the minor number comparison check. > > Now requesting for MISC_DYNAMIC_MINOR as the minor > > number for twl4030_watchdog and renamed the device name as > > "twl4030_watchdog". > > > > Tested for basic boot up on OMAP4 Blaze and OMAP3630 SDP. OMAP3630 SDP > > twl4030_wdt registration succeeds.2430SDP boot tested, watchdog registration > > without errors. > > > > Signed-off-by: Keerthy <j-keer...@ti.com>
NAK. Reason: a watchdog daemon will only be using /dev/watchdog. The plan is to get the generic watchdog framework in, convert most of the drivers, extend teh generic watchdog framework with a sysfs interface so that we can support multiple watchdogs. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
