> -----Original Message-----
> From: Menon, Nishanth
> Sent: Thursday, May 12, 2011 11:32 PM
> To: Premi, Sanjeev
> Cc: [email protected]
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> On Thu, May 12, 2011 at 12:36, Sanjeev Premi <[email protected]> wrote:
> > There is an implicit assumption in current implementation that
> > debugfs is always enabled.
> thanks for doing this.
> >
> > When debugfs is disabled, these errors are noticed during boot:
> > omap_voltage_late_init: Unable to create voltage debugfs main dir
> > vdd_debugfs_init: Unable to create debugfs directory for vdd_mpu
> > vdd_debugfs_init: Unable to create debugfs directory for vdd_core
> >
> > This patch fixes these errors by enclosing code related to debugfs
> > in #ifdef CONFIG_DEBUG_FS..#endif.
>
> generic - couple of comments - I think the #defs should be isolated
> off to headers - maybe the right approach may be to move the debugfs
[sp] None of the code encapsulated here is "header" material.
I guess you have seen the patch below.
> entries off to a separate file? or pm-debug.c??
[sp] I wish it was all debug code. It is "operational" code.
Check the Kconfig in plat-omap. Smartreflex is not even expected
to work without debugfs. Though I believe much of the data put in
debugfs can be in local lists/structures.
That was supposed to be my next set of patches - as I understand
the implementation better.
>
> >
> > Boot tested on OMAP3EVM.
> >
> > Signed-off-by: Sanjeev Premi <[email protected]>
> > ---
> > Patch was created and tested on the pm branch at commit:
> > d695569 : rebuild PM from branches
>
> Could I suggest Kevin's volt cleanup series - based off _c branch if
> there are cleanups to be done?
[sp] I didn't see it updated for 5 weeks. hence used this.
but patch should apply cleanly...
>
> >
> > I am still finding my way around new code sructure. Haven't
> > been able to verify if smartreflex and voltage layer are
> > properly initialized. Though I do understand that smartreflex
> > won't work without debugfs.
> >
>
> Last I tried, with Vishwa's dvfs branch on panda without voltage
> registrations, things could crash :( if I get some time I will try to
> port Vishwa's series onto kevin's branch as well and test and provide
> any patches necessary.
[sp] I can try this on Panda. Will be able to get one tomorrow.
~sanjeev
[snip]...[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
