> -----Original Message----- > From: Vladimir Pantelic [mailto:[email protected]] > Sent: Wednesday, June 15, 2011 3:46 PM > To: Kernel development list > Cc: [email protected]; Hiremath, Vaibhav > Subject: Re: [PATCH] omap v4l2: fix wrong resizer calculation > > ping [Hiremath, Vaibhav] Sorry for delayed response, somehow I completely missed this patch.
Thanks for finding this bug, the patch looks ok to me. Only one suggestion I have is to update the description of patch commit, request you to change like following - ---- The omap_vout_new_crop() function has possible bug, uses uninitialized variable "crop.width/height" which is actually output of the function. Instead we should be using "try_crop.width/height" to calculate the resizer value. ---- Rest everything looks ok, while submitting patch again you can add my ack; I will queue to my Arago repo. Also I have tested this patch on OMAP3EVM platform, and it seems to be working fine. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
