[...] > > > Simplify omap2_gpio_prepare_for_idle() and > omap2_gpio_resume_after_idle() > > by moving most of the stuff to *_pm_runtime_suspend() and > *_pm_runtime_resume(). > > Also, omap_gpio_suspend() and omap_gpio_resume() optimized to operate > per > > GPIO bank instead of operating on entire list every time. > > This second part should be a separate patch. OK.
> > > Signed-off-by: Tarun Kanti DebBarma <[email protected]> > > Signed-off-by: Charulatha V <[email protected]> > > [...] > > > > > +#ifdef CONFIG_ARCH_OMAP2PLUS > > +static void omap_gpio_save_context(struct gpio_bank *bank); > > +static void omap_gpio_restore_context(struct gpio_bank *bank); > > +#endif > > + > > static int omap_gpio_pm_runtime_suspend(struct device *dev) > > { > > +#ifdef CONFIG_ARCH_OMAP2PLUS > > c.f. #ifdefs are ugly in Documentation/SubmittingPatches > > Just wrap all of these funcions: runtime PM, save/restore context, > prepare/resume from idle inside the #ifdef. Then have an else > clause with NULL versions of the runtime PM functions. OK. -- Tarun > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
