On Thu, Jun 23, 2011 at 09:04:20AM -0600, Paul Walmsley wrote:
> Since this is basically a hack to work around limitations of the current
> MMC driver, if we accept something like this, I think it should come with
> a big warning message and comment. Something like this in
> omap44xx_clockdomains_init():
>
> /*
> * XXX The OMAP L3 interconnect hardware is able to enter
> * hardware-supervised idle. But because the OMAP HSMMC
> * driver still hasn't been converted to use runtime PM, if
> * the L3 is allowed to enter hwsup idle, the kernel will
> * crash. Once the MMC driver is fixed (which patches have
> * been posted to do, with subject line "OMAP: HSMMC: cleanup
> * and runtime pm") the change to the l3_init_44xx_clkdm
> * flags should be dropped. It limits the low-power state that
> * the chip can enter.
> */
> pr_warn("WARNING: OMAP4 low power states artificially limited, due
> to unconverted HSMMC driver\n");
Do you really want to continue pissing Linus off with churn like this
rather than pressing to get problems fixed _properly_ (eg, getting the
HSMMC driver fixed) ?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
