> -----Original Message-----
> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk]
> Sent: Friday, June 24, 2011 7:32 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCHv2] omap2+: pm: cpufreq: Fix
> loops_per_jiffy calculation
[snip]...[snip]
> >
> > +#ifdef CONFIG_SMP
> > + /* Adjust jiffies before transition */
> > + for_each_cpu(i, policy->cpus) {
> > + unsigned long lpj = per_cpu(cpu_data,
> i).loops_per_jiffy;
> > +
> > + per_cpu(cpu_data, i).loops_per_jiffy =
> cpufreq_scale(lpj,
> > + freqs.old,
> > + freqs.new);
> > + }
> > +#endif
> > +
>
> You didn't listen to what I told you. It'll be quicker for
> me to write
> this patch myself if you send me the *original* file.
>
Russell,
The function adjust_jiffies() is no-op for CONFIG_SMP - but it
is not the case with cpufreq_scale().
So, when CONFIG_SMP is defined, then loops_per_jiffy would be
calculated for both UP and SMP processors.
Did I miss something else?
~sanjeev
[snip]...[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
