Shubhrajyoti D <[email protected]> writes: > The reset in the driver at init is not needed > anymore as the hwmod framework takes care of > reseting it.
Agreed, but... The addition of the new places for reset (after timeout, after error) is not immediately clear, and not described here at all. After digging myself (since it wasn't described in the changelog), I see that since the reset was removed from omap_i2c_init(), which was called not only during probe, but also after time out and error handling, new reset calls were added back in those locations. This is the kind of thing that needs to be thoroughly described in the changelog so reviewers who are not necessarily experts in this driver will easily and *quickly* understand what is going on without having to dig into all the details themselves. Summary: Descriptive, detailed changelogs are invaluable to reviewers/maintainers. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
