Hi, On Fri, Sep 2, 2011 at 10:43 AM, Tomi Valkeinen <[email protected]> wrote: > On Fri, 2011-09-02 at 10:41 +0530, K, Mythri P wrote: >> Hi, >> >> On Thu, Sep 1, 2011 at 1:57 PM, Tomi Valkeinen <[email protected]> wrote: >> > On Mon, 2011-08-29 at 11:44 +0530, [email protected] wrote: >> >> From: Mythri P K <[email protected]> >> >> >> >> As the pll and the video configuration info are part of the ip_data those >> >> structures are moved to the ip_data strtucure.Also the functions are >> >> modified >> >> accordingly to take care of this movement. >> > >> > structure typoed, and use a space after period. >> > >> >> Signed-off-by: Mythri P K <[email protected]> >> >> --- >> >> drivers/video/omap2/dss/hdmi.c | 34 +++++++++++++++------------------- >> >> drivers/video/omap2/dss/hdmi.h | 18 ++++++++++-------- >> >> 2 files changed, 25 insertions(+), 27 deletions(-) > >> >> -static int hdmi_pll_program(struct hdmi_ip_data *ip_data, >> >> - struct hdmi_pll_info *fmt) >> >> +static int hdmi_pll_program(struct hdmi_ip_data *ip_data) >> >> { >> >> u16 r = 0; >> >> enum hdmi_clk_refsel refsel; >> >> @@ -399,7 +397,7 @@ static int hdmi_pll_program(struct hdmi_ip_data >> >> *ip_data, >> >> >> >> refsel = HDMI_REFSEL_SYSCLK; >> >> >> >> - r = hdmi_pll_init(ip_data, refsel, fmt->dcofreq, fmt, fmt->regsd); >> >> + r = hdmi_pll_init(ip_data, refsel); >> > >> > I don't think I quite understood why refsel is not part of the pll info. >> > And if it has to be hardcoded, you could as well do that in >> > hdmi_pll_init(). >> > >> Ok , yes that is better. > > So, why refsel is not part of the pll info? The HW doesn't support > changing it? If so, is it only for OMAPs or for all SoCs? It is a variable parameter ,H/w supports changing it but it is never tried, I was considering hard-coding it in the hdmi.c and passing it, so that there would be no hard-coding in IP functions.
Thanks and regards, Mythri. > > Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
