Hi Joerg, On Wednesday 14 September 2011 16:07:39 Joerg Roedel wrote: > Without this patch it is possible to select the VIDEO_OMAP3 > driver which then selects OMAP_IOVMM. But the omap iommu > driver is not compiled without IOMMU_SUPPORT enabled. Fix > that by forcing OMAP_IOMMU and OMAP_IOVMM are enabled before > VIDEO_OMAP3 can be selected.
What about making VIDEO_OMAP3 select IOMMU_SUPPORT instead then ? Your patch would make the OMAP3 ISP driver disappear from the menu until IOMMU_SUPPORT gets turned on, which can confuse users. > Cc: Ohad Ben-Cohen <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Joerg Roedel <[email protected]> > --- > drivers/iommu/Kconfig | 4 ++-- > drivers/media/video/Kconfig | 3 +-- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index d901930..ae46776 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -114,8 +114,8 @@ config OMAP_IOMMU > select IOMMU_API > > config OMAP_IOVMM > - tristate > - select OMAP_IOMMU > + tristate "OMAP IO Virtual Memory Manager Support" > + depends on OMAP_IOMMU > > config OMAP_IOMMU_DEBUG > tristate "Export OMAP IOMMU/IOVMM internals in DebugFS" > diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig > index 6a25fad..6201069 100644 > --- a/drivers/media/video/Kconfig > +++ b/drivers/media/video/Kconfig > @@ -763,8 +763,7 @@ source "drivers/media/video/m5mols/Kconfig" > > config VIDEO_OMAP3 > tristate "OMAP 3 Camera support (EXPERIMENTAL)" > - select OMAP_IOVMM > - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && ARCH_OMAP3 && > EXPERIMENTAL > + depends on OMAP_IOVMM && VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && > ARCH_OMAP3 && EXPERIMENTAL > ---help--- > Driver for an OMAP 3 camera controller. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
