On Mon, Sep 19, 2011 at 11:37:37AM +0530, Hiremath, Vaibhav wrote: > > > -----Original Message----- > > From: [email protected] [mailto:linux-omap- > > [email protected]] On Behalf Of Laurent Pinchart > > Sent: Monday, September 19, 2011 3:29 AM > > To: Martin Hostettler > > Cc: Tony Lindgren; [email protected]; linux- > > [email protected]; [email protected] > > Subject: Re: [PATCH v2] arm: omap3evm: Add support for an MT9M032 based > > camera board. > > > > Hi Martin, > > > > On Saturday 17 September 2011 11:34:57 Martin Hostettler wrote: > > > Adds board support for an MT9M032 based camera to omap3evm. > > > > > > Sigend-off-by: Martin Hostettler <[email protected]> > > > --- > > > arch/arm/mach-omap2/Makefile | 1 + > > > arch/arm/mach-omap2/board-omap3evm-camera.c | 183 > > > +++++++++++++++++++++++++++ 2 files changed, 184 insertions(+), 0 > > > deletions(-) > > > create mode 100644 arch/arm/mach-omap2/board-omap3evm-camera.c > > > > > > Changes in V2: > > > * ported to current mainline > > > * Style fixes > > > * Fix error handling > > > > > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > > > index f343365..8ae3d25 100644 > > > --- a/arch/arm/mach-omap2/Makefile > > > +++ b/arch/arm/mach-omap2/Makefile > > > @@ -202,6 +202,7 @@ obj-$(CONFIG_MACH_OMAP3_TORPEDO) += > > > board-omap3logic.o \ obj-$(CONFIG_MACH_OVERO) += > > > board-overo.o \ > > > hsmmc.o > > > obj-$(CONFIG_MACH_OMAP3EVM) += board-omap3evm.o \ > > > + board-omap3evm-camera.o \ > > > hsmmc.o > > > obj-$(CONFIG_MACH_OMAP3_PANDORA) += board-omap3pandora.o \ > > > hsmmc.o > > > diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c > > > b/arch/arm/mach-omap2/board-omap3evm-camera.c new file mode 100644 > > > index 0000000..be987d9 > > > --- /dev/null > > > +++ b/arch/arm/mach-omap2/board-omap3evm-camera.c > > > @@ -0,0 +1,183 @@ > > > +/* > > > + * Copyright (C) 2010-2011 Lund Engineering > > > + * Contact: Gil Lund <[email protected]> > > > + * Author: Martin Hostettler <[email protected]> > > > + * > [Hiremath, Vaibhav] The file below seems copied from (which is coming from > all older releases of TI) > > http://arago-project.org/git/projects/?p=linux-omap3.git;a=blob;f=arch/arm/mach-omap2/board-omap3evm-camera.c;h=2e6ccfef69027dee880d507b98b5a7998d4bbe7e;hb=adcd067326836777c049e3cb32a5b7d9d401fc31 > > So I would appreciate if you keep original copyright and authorship of the > file and add your sign-off to the patch. >
First of all i don't have any problem Adding your name and the TI copyright. Maybe i should have been more careful when looking at and adeption omap3evm_set_mux as i really took that from the TI code. I honestly don't remember if i took any other code from that file or not. It ends up doing what the hardware needs anyway. For me it doesn't matter with such trival things, but i should have been more careful. Do you consider it resolved if use the following at the start? /* * Copyright (C) 2010 Texas Instruments Inc * Copyright (C) 2010-2011 Lund Engineering * Contact: Gil Lund <[email protected]> * Authors: * Vaibhav Hiremath <[email protected]> * Martin Hostettler <[email protected]> */ But then again the copy on my harddisk has these too... * Contributors: * Anuj Aggarwal <[email protected]> * Sivaraj R <[email protected]> Maybe i should add them too. Not sure really... - Martin Hostettler -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
