Re: [PATCH v8 16/24] gpio/omap: use pm-runtime framework

[DebBarma, Tarun Kanti]

On Fri, Nov 4, 2011 at 10:43 PM, Kevin Hilman <khil...@ti.com> wrote:
> Tarun Kanti DebBarma <tarun.ka...@ti.com> writes:
>
>> Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
>> for enabling/disabling clocks appropriately. Remove syscore_ops and
>> instead use SET_RUNTIME_PM_OPS macro.
>>
>> Signed-off-by: Charulatha V <ch...@ti.com>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.ka...@ti.com>
>> Reviewed-by: Santosh Shilimkar <santosh.shilim...@ti.com>
>> ---
>>  arch/arm/mach-omap2/gpio.c |    2 -
>>  drivers/gpio/gpio-omap.c   |   67 
>> +++++++++++++++++++++++++++++---------------
>>  2 files changed, 44 insertions(+), 25 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
>> index 5ae1cf3..a992802 100644
>> --- a/arch/arm/mach-omap2/gpio.c
>> +++ b/arch/arm/mach-omap2/gpio.c
>> @@ -146,8 +146,6 @@ static int omap2_gpio_dev_init(struct omap_hwmod *oh, 
>> void *unused)
>>               return PTR_ERR(od);
>>       }
>>
>> -     omap_device_disable_idle_on_suspend(od);
>> -
>
> No description in the changelog about this change.  (Yes, I understand
> why it's removed, but it needs to be described in the changelog so when
> I forget, I'll have a way to remember.)
Yes, I will put a description explaining that this is not needed after
driver is runtime adapted.
--
Tarun
>
> Kevin
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html