On Mon, Nov 28, 2011 at 04:53:24PM +0200, Tero Kristo wrote:
> +++ b/drivers/regulator/twl-regulator.c
> @@ -18,6 +18,7 @@
> #include <linux/regulator/machine.h>
> #include <linux/i2c/twl.h>
>
> +#include <plat/voltage.h>
You shouldn't be including platform specific headers in generic code.
> + /* voltagedomain, only used for VP controlled smps regulators */
> + union {
> + const char *name;
> + struct voltagedomain *ptr;
> + } voltdm;
> +
This looks pretty icky... Why are you using a union of a pointer to a
struct and a name? How do things know which to use?
> - twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE_SMPS_4030,
> - vsel);
> + if (info->voltdm.ptr)
> + voltdm_scale(info->voltdm.ptr, min_uV);
> + else {
Use braces on both branches.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
