* Ohad Ben-Cohen <[email protected]> [111207 23:26]: > Hi Tony, > > On Tue, Oct 25, 2011 at 11:48 AM, Ohad Ben-Cohen <[email protected]> wrote: > > Add a remoteproc driver for OMAP4, so we can boot the dual-M3 "Ducati" > > and DSP subsystems. > > > > Use the omap_device_* API to control the hardware state, and utilize > > the OMAP mailbox to interrupt the remote processor when a new message > > is pending (the mailbox payload is used to tell it which virtqueue was > > the message placed in). > > > > Conversely, when an inbound mailbox message arrives, tell the remoteproc > > core which virtqueue is triggered. > > > > Later we will also use the mailbox payload to signal omap-specific > > events like remote crashes (which will be used to trigger remoteproc > > recovery) and power management transitions. At that point we will also > > extend the remoteproc core to support this. > > > > Based on (but now quite far from) work done by Fernando Guzman Lugo > > <[email protected]> and Hari Kanigeri <[email protected]>. > > > > Designed with Brian Swetland <[email protected]>. > > > > Signed-off-by: Ohad Ben-Cohen <[email protected]> > > Cc: Brian Swetland <[email protected]> > > Cc: Arnd Bergmann <[email protected]> > > Cc: Grant Likely <[email protected]> > > Cc: Tony Lindgren <[email protected]> > > Cc: Russell King <[email protected]> > > Cc: Rusty Russell <[email protected]> > > Cc: Andrew Morton <[email protected]> > > Cc: Greg KH <[email protected]> > > Cc: Stephen Boyd <[email protected]> > > --- > > arch/arm/plat-omap/include/plat/remoteproc.h | 56 ++++++ > > drivers/amp/remoteproc/Kconfig | 21 +++ > > drivers/amp/remoteproc/Makefile | 4 +- > > drivers/amp/remoteproc/omap_remoteproc.c | 248 > > ++++++++++++++++++++++++++ > > drivers/amp/remoteproc/omap_remoteproc.h | 69 +++++++ > > 5 files changed, 397 insertions(+), 1 deletions(-) > > create mode 100644 arch/arm/plat-omap/include/plat/remoteproc.h > > create mode 100644 drivers/amp/remoteproc/omap_remoteproc.c > > create mode 100644 drivers/amp/remoteproc/omap_remoteproc.h > > I'm about to add this to linux-next (minus the 'amp' wording); can I > please have your Acked-by for this (at least for the plat-omap change) ?
The platform init code looks OK to me. Please also start considering how to do the DT bindings for it. For patches 4 & 5: Acked-by: Tony Lindgren <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
