On Fri, 2011-12-09 at 15:23 -0800, Kevin Hilman wrote: > Tero Kristo <[email protected]> writes: > > > PM interrupt handling is now done through the PRCM chain handler. The > > interrupt handling logic is also split in two parts, to serve IO and > > WKUP events separately. This allows us to handle IO chain events in a > > clean way. > > Also, elaborate that this means this core event code should no longer > clear the IO events since they are now handled by their own handlers.
Okay. > > > Signed-off-by: Tero Kristo <[email protected]> > > [...] > > > @@ -880,12 +848,20 @@ static int __init omap3_pm_init(void) > > * supervised mode for powerdomains */ > > prcm_setup_regs(); > > > > - ret = request_irq(INT_34XX_PRCM_MPU_IRQ, > > - (irq_handler_t)prcm_interrupt_handler, > > - IRQF_DISABLED, "prcm", NULL); > > + ret = request_irq(omap_prcm_event_to_irq("wkup"), > > + _prcm_int_handle_wakeup, 0, "pm_wkup", NULL); > > + > > + if (ret) { > > + printk(KERN_ERR "Failed to request pm_wkup irq\n"); > > + goto err1; > > + } > > + > > + /* IO interrupt is shared with mux code */ > > + ret = request_irq(omap_prcm_event_to_irq("io"), > > + _prcm_int_handle_io, IRQF_SHARED, "pm_io", omap3_pm_init); > > + > > Why does the "hwmod_io" use IRQF_NO_SUSPEND and this one doesn't? Hmm, good question. Must have been a remain from some old tweak, I'll take a look at what the flags should actually be. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
