Hi, On Mon, Dec 19, 2011 at 10:21:36AM -0500, Alan Stern wrote: > On Mon, 19 Dec 2011, Felipe Balbi wrote: > > > those routines have everything we need to map/unmap > > USB requests and it's better to use them. > > > > Signed-off-by: Felipe Balbi <[email protected]> > > --- > > drivers/usb/gadget/net2280.c | 19 +++++++++---------- > > 1 files changed, 9 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c > > index cf1f364..59d4794 100644 > > --- a/drivers/usb/gadget/net2280.c > > +++ b/drivers/usb/gadget/net2280.c > > > @@ -857,10 +853,13 @@ net2280_queue (struct usb_ep *_ep, struct usb_request > > *_req, gfp_t gfp_flags) > > return -EOPNOTSUPP; > > > > /* set up dma mapping in case the caller didn't */ > > - if (ep->dma && _req->dma == DMA_ADDR_INVALID) { > > - _req->dma = pci_map_single (dev->pdev, _req->buf, _req->length, > > - ep->is_in ? PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); > > - req->mapped = 1; > > + if (ep->dma) { > > + int ret; > > + > > + ret = usb_gadget_map_request(&dev->gadget, &req->req, > > + ep->is_in); > > As mentioned for the goku patch, &req->req can be replaced by _req.
sure -- balbi
signature.asc
Description: Digital signature
