On Tue, Feb 07, 2012 at 03:01:18PM +0200, Peter Ujfalusi wrote:
> twl6040 has three power supply source:
> VBAT needs to be connected to VBAT, VIO, and V2V1.
> Add regulator support for the VIO, V2V1 supplies.
> Initially handle the two supply together with bulk commands.

> Signed-off-by: Peter Ujfalusi <[email protected]>

Reviewed-by: Mark Brown <[email protected]>

> +     twl6040->supplies = devm_kzalloc(&client->dev,
> +                                      sizeof(struct regulator_bulk_data) *
> +                                      TWL6040_NUM_SUPPLIES, GFP_KERNEL);
> +     if (!twl6040->supplies) {
> +             ret = -ENOMEM;
> +             goto err;
> +     }
> +

though I'd be inclined to just embed this structure into the twl6040
struct directly, you're always going to need to allocate it and it saves
a tiny bit of error handling and whatnot.

Attachment: signature.asc
Description: Digital signature

Reply via email to