Tero Kristo <[email protected]> writes: > mpu_iva voltdm usecount is now decreased during idle. This will > allow the voltagedomain to reflect actual usage, and will allow > proper usage of vc callbacks.
I don't follow why this is needed in the idle path. Why aren't the usecounts from clock/powerdomain disables (enables) causing this voltdm disable (enable) to happen automatcially? If these are needed, seems like they should be in the pwrdm_[pre|post]_transition() hooks so they can be generic. Kevin > Signed-off-by: Tero Kristo <[email protected]> > Cc: Paul Walmsley <[email protected]> > Cc: Kevin Hilman <[email protected]> > --- > arch/arm/mach-omap2/pm34xx.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c > index fc69875..14defaf 100644 > --- a/arch/arm/mach-omap2/pm34xx.c > +++ b/arch/arm/mach-omap2/pm34xx.c > @@ -74,6 +74,7 @@ void (*omap3_do_wfi_sram)(void); > static struct powerdomain *mpu_pwrdm, *neon_pwrdm; > static struct powerdomain *core_pwrdm, *per_pwrdm; > static struct powerdomain *cam_pwrdm; > +static struct voltagedomain *mpu_iva_voltdm; > > static inline void omap3_per_save_context(void) > { > @@ -311,6 +312,8 @@ void omap_sram_idle(void) > return; > } > > + voltdm_pwrdm_disable(mpu_iva_voltdm); > + > /* NEON control */ > if (pwrdm_read_pwrst(neon_pwrdm) == PWRDM_POWER_ON) > pwrdm_set_next_pwrst(neon_pwrdm, mpu_next_state); > @@ -393,6 +396,8 @@ void omap_sram_idle(void) > } > omap3_intc_resume_idle(); > > + voltdm_pwrdm_enable(mpu_iva_voltdm); > + > pwrdm_post_transition(); > > /* PER */ > @@ -828,6 +833,9 @@ static int __init omap3_pm_init(void) > > (void) clkdm_for_each(clkdms_setup, NULL); > > + mpu_iva_voltdm = voltdm_lookup("mpu_iva"); > + voltdm_pwrdm_enable(mpu_iva_voltdm); > + > mpu_pwrdm = pwrdm_lookup("mpu_pwrdm"); > if (mpu_pwrdm == NULL) { > printk(KERN_ERR "Failed to get mpu_pwrdm\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
