On Wed, Feb 22, 2012 at 10:52:52AM +0200, Ohad Ben-Cohen wrote:
> @@ -274,7 +274,7 @@ static ssize_t debug_read_mem(struct file *file, char 
> __user *userbuf,
>       mutex_lock(&iommu_debug_lock);
>  
>       area = omap_find_iovm_area(dev, (u32)ppos);
> -     if (IS_ERR(area)) {
> +     if (IS_ERR_OR_NULL(area)) {
>               bytes = -EINVAL;

There's something else which needs fixing here - the return code.  If
omap_find_iovm_area() returns an error code that needs propagating.
Otherwise it might as well just return NULL for all errors.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to