Hi Tony, On 02/23/2012 01:07 AM, Tony Lindgren wrote: > * Peter Ujfalusi <[email protected]> [120217 00:54]: >> CCDN is the last common channel register in all OMAP4 versions. Use >> cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not >> doing what it supposed to do. > > This is a bit unclear.. Which is not doing what is supposed to do? > DMA driver? Or one of the cpu_is_omap?
The cpu_is_omap4430() returns 0 unconditionally. Because of this the dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430). > If this should be queued as a fix, then we need some kind of > description here what breaks. I will resend the patch with a better commit message. This is a bug for sure, but I'm not sure how severe it is. At best we are not clearing the registers between CCFN, and CCDN on OMAP4. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
