Re: [PATCH 1/3] ARM: OMAP: dmtimer: Use devm_ API and do some cleanup in probe()

[DebBarma, Tarun Kanti]

On Mon, Apr 16, 2012 at 8:32 PM, Shubhrajyoti <shubhrajy...@ti.com> wrote:
> On Monday 16 April 2012 05:55 PM, Tarun Kanti DebBarma wrote:
>> Replace the regular kzalloc and ioremap with the devm_ equivalent
>> to simplify error handling. We don't need kree() anymore in
>> omap_dm_timer_remove().
>>
>> Also added *dev* pointer to reference pdev->dev which makes the
>> usage shorter in code.
>>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.ka...@ti.com>
>> ---
>>
> <snip>
>> -     timer->io_base = ioremap(mem->start, resource_size(mem));
>> +     timer->io_base = devm_ioremap(dev, mem->start, resource_size(mem));
>>       if (!timer->io_base) {
> Could we use  devm_request_and_ioremap here?
>
Yes, I will change. Thanks.
--
Tarun
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html