Re: [PATCH 2/7] UART: OMAP: Cut the clock in the error cases

[Shubhrajyoti]

On Wednesday 18 April 2012 07:30 PM, Kevin Hilman wrote:
>>>> >>>                if (ret < 0) {
>>>> >>>                        serial_omap_enable_ier_thri(up);
>>>> >>> +                      pm_runtime_mark_last_busy(&up->pdev->dev);
>>>> >>> +                      pm_runtime_put_autosuspend(&up->pdev->dev);
>>> >> Why the autosuspend version here?
>>> >>
>>> >> Kevin
>>> >>
>>> >>
>> > In case the request_dma fails we enable the thri( effectively like intr
>> > mode) so
>> > I thought of using the autosuspend version here .
>> >
>> > Do you prefer put version instead ?
> Not necessarily, it should just be well described in the changelog.
>
> Kevin
Yes agree completely. Will describe that in the changelog.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html