On Tue, 2012-05-08 at 15:28 +0530, Archit Taneja wrote: > Replace the function dispc_mgr_set_timings() with dss_mgr_set_timings() in the > interface drivers. The latter function ensures that the timing related DISPC > registers are configured according to the shadow register programming model. > > Signed-off-by: Archit Taneja <[email protected]> > --- > drivers/video/omap2/dss/dpi.c | 2 +- > drivers/video/omap2/dss/dsi.c | 5 ++--- > drivers/video/omap2/dss/hdmi.c | 2 +- > drivers/video/omap2/dss/rfbi.c | 4 ++-- > drivers/video/omap2/dss/sdi.c | 2 +- > drivers/video/omap2/dss/venc.c | 2 +- > 6 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/video/omap2/dss/dpi.c b/drivers/video/omap2/dss/dpi.c > index cec1166..5d84ab0 100644 > --- a/drivers/video/omap2/dss/dpi.c > +++ b/drivers/video/omap2/dss/dpi.c > @@ -156,7 +156,7 @@ static int dpi_set_mode(struct omap_dss_device *dssdev) > t->pixel_clock = pck; > } > > - dispc_mgr_set_timings(dssdev->manager->id, t); > + dss_mgr_set_timings(dssdev->manager, t); > > return 0; > }
I think you can now remove the dispc_mgr_go() from dpi.c in this patch. And something else, which doesn't need to be fixed now, but just to point out: dpi_set_timings() currently uses runtime_get to enable the HW. If everything was in proper shape, this wouldn't be needed. dpi_set_timings() would call apply.c's functions, and if the output is disabled, the settings would just be stored in ram. So there wouldn't be any need to enable the HW with runtime_get(). Then again, if we do change clock settings or non-shadow registers in dpi_set_timings(), then that's not possible (at least via apply.c's caching system). Tomi
signature.asc
Description: This is a digitally signed message part
