On 05/25/2012 05:42 AM, [email protected] wrote:
> From: Xiao Jiang <[email protected]>
> 
> Add wdt node to support dt.
> 
> Signed-off-by: Xiao Jiang <[email protected]>
> ---
>  arch/arm/boot/dts/omap3.dtsi |    5 +++++
>  arch/arm/boot/dts/omap4.dtsi |    5 +++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 99474fa..039df5c 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -215,5 +215,10 @@
>                       compatible = "ti,omap3-hsmmc";
>                       ti,hwmods = "mmc3";
>               };
> +
> +             wdt: wdt@48314000{

Minor comment, may be call this wdt2 as this is watchdog timer 2. Also
ass a space between the address and the "{".

> +                     compatible = "ti,omap3-wdt";
> +                     ti,hwmods = "wd_timer2";
> +             };
>       };
>  };
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 359c497..d01403d 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -272,5 +272,10 @@
>                       ti,hwmods = "mmc5";
>                       ti,needs-special-reset;
>               };
> +
> +             wdt: wdt@4a314000{

Same as above.

> +                     compatible = "ti,omap4-wdt";
> +                     ti,hwmods = "wd_timer2";
> +             };
>       };
>  };

Also we should add some documentation to describe the binding. Here it
is very simple, but nonetheless we should have something as we have for
gpio [1].

Cheers
Jon

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/devicetree/bindings/gpio/gpio-omap.txt;h=bff51a2fee1eae7d387b40ea913e04782554bf68;hb=HEAD
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to