On Mon, Jul 30, 2012 at 06:40:43PM +0100, Mark Brown wrote:
> On Mon, Jul 30, 2012 at 05:44:44PM +0100, Russell King - ARM Linux wrote:
>
> > -#define TWLRES_OF_MATCH(comp, label) TWL_OF_MATCH(comp, TWLRES, label)
> > - TWLRES_OF_MATCH("ti,twl6030-clk32kg", CLK32KG),
>
> > but completely forgets that this:
>
> > TWL6030_FIXED_RESOURCE(CLK32KG, 0x8C, 0);
>
> > defines a structure that it was using. (Welcome to why macros are horrid
> > when they hide the names of stuff they create.)
>
> I actually have the fix in a separate patch which completely removes
> the "regulator" but wasn't happy about pushing the patch for 3.6 since I
> can't test (I don't think anyone's ever actually used those and
> obviously they should be using the clk API now).
If the structure is unused, the fix is to delete the
"TWL6030_FIXED_RESOURCE(CLK32KG, 0x8C, 0);" line because nothing is using
that (if it was, we wouldn't end up with the warning).
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
