On Tue, Aug 21, 2012 at 4:05 PM, Tomi Valkeinen <[email protected]> wrote: > On Mon, 2012-08-20 at 18:53 +0530, Chandrabhanu Mahapatra wrote: >> All the cpu_is checks have been moved to dss_init_features function >> providing a >> much more generic and cleaner interface. The OMAP version and revision >> specific >> initializations in various functions are cleaned and the necessary data are >> moved to dss_features structure which is local to dss.c. >> >> Signed-off-by: Chandrabhanu Mahapatra <[email protected]> >> --- >> drivers/video/omap2/dss/dss.c | 117 >> ++++++++++++++++++++++++++--------------- >> 1 file changed, 76 insertions(+), 41 deletions(-) >> >> diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c >> index 10566ae..f6d3d0a 100644 >> --- a/drivers/video/omap2/dss/dss.c >> +++ b/drivers/video/omap2/dss/dss.c >> @@ -31,6 +31,7 @@ >> #include <linux/clk.h> >> #include <linux/platform_device.h> >> #include <linux/pm_runtime.h> >> +#include <linux/gfp.h> >> >> #include <video/omapdss.h> >> >> @@ -65,6 +66,12 @@ struct dss_reg { >> static int dss_runtime_get(void); >> static void dss_runtime_put(void); >> >> +struct dss_features { >> + u16 fck_div_max; >> + int dss_fck_multiplier; >> + char *clk_name; > > const char * > > Tomi >
All the values are const. So we have a const pointer dss.feat to hold this structure. Is a separate const char *clk_name required? -- Chandrabhanu Mahapatra Texas Instruments India Pvt. Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
