On Wed, 2012-09-05 at 14:45 +0530, Archit Taneja wrote: > On Wednesday 05 September 2012 01:55 PM, Tomi Valkeinen wrote: > > dss_mgr_set_timings() can only be called when the output is not active. > > This means that most of the code in the function is extra, as there's no > > need to write the values to registers, etc, because that will be handled > > when the output will be enabled. > > We need to fix dpi_set_timings() before we can make this change. DPI > still tries to change timings on the fly, i.e, with manager enabled. We > need to disable and enable the DPI output like we do for other outputs.
Yep, and for HDMI also (I didn't check the others yet). I think the simplest way to handle this is to only write the dpi.timings in omapdss_dpi_set_timings, and remove the call to dss_mgr_set_timings. This is not perfect, as a call to omapdss_dpi_set_timings when the display is enabled would result in changing the dpi.timings, but the changes wouldn't be actually in use. However, there are only a few places where set_timings is called, and we can make sure in those places to first disable the output and then enable it again. Tomi
signature.asc
Description: This is a digitally signed message part
