Jean Pihet <[email protected]> writes: > Hello, > > On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun <[email protected]> wrote: >> From: Wei Yongjun <[email protected]> >> >> In case of error, the function voltdm_lookup() returns NULL >> not ERR_PTR(). The IS_ERR() test in the return value check >> should be replaced with NULL test. >> >> dpatch engine is used to auto generate this patch. >> (https://github.com/weiyj/dpatch) >> >> Signed-off-by: Wei Yongjun <[email protected]> >> --- >> arch/arm/mach-omap2/sr_device.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/sr_device.c >> b/arch/arm/mach-omap2/sr_device.c >> index d033a65..c248b30 100644 >> --- a/arch/arm/mach-omap2/sr_device.c >> +++ b/arch/arm/mach-omap2/sr_device.c >> @@ -123,7 +123,7 @@ static int __init sr_dev_init(struct omap_hwmod *oh, >> void *user) >> sr_data->senp_mod = 0x1; >> >> sr_data->voltdm = voltdm_lookup(sr_dev_attr->sensor_voltdm_name); >> - if (IS_ERR(sr_data->voltdm)) { >> + if (!sr_data->voltdm) { >> pr_err("%s: Unable to get voltage domain pointer for VDD >> %s\n", >> __func__, sr_dev_attr->sensor_voltdm_name); >> goto exit; > > This looks good, so here is the ack: > Acked-by: Jean Pihet <[email protected]> >
Thanks, queuing this one for v3.7-rc. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
