On 17:46-20121106, Tony Lindgren wrote: > * Nishanth Menon <[email protected]> [121106 17:30]: > > On 17:18-20121106, Tony Lindgren wrote: > > > * Nishanth Menon <[email protected]> [121106 13:50]: > > > > On 10:49-20121106, Tony Lindgren wrote: > > > > > > > > > > Looks like there are other things there too that's not platform data: > > > > > > > > > > struct voltagedomain *voltdm_lookup(const char *name); > > > > > int voltdm_scale(struct voltagedomain *voltdm, unsigned long > > > > > target_volt); > > > > > unsigned long voltdm_get_voltage(struct voltagedomain *voltdm); > > > > > struct omap_volt_data *omap_voltage_get_voltdata(struct voltagedomain > > > > > *voltdm, > > > > > unsigned long volt); > > > > > > > > > > Can you please add a patch fixing that ASAP? > > > > > > > > Agreed include/linux/platform_data/voltage-omap.h has more functions as > > > > well. > > > > Considering it did: > > > > rename arch/arm/plat-omap/include/plat/voltage.h => > > > > include/linux/platform_data/voltage-omap.h > > > > > > > > Where do we move these functions to? > > > > > > > > drivers/power/avs/smartreflex.c needs: > > > > omap_voltage_get_voltdata > > > > and > > > > drivers/power/avs/smartreflex-class3.c > > > > will need voltdm_reset and voltdm_get_voltage > > > > > > How about something local drivers/power/avs/smartreflex.h? > > These APIs are exposed by voltage layer, not smartreflex :( > > stuff like voltdm_scale will have to be used by regulator logic > > eventually, so moving to AVS driver header is probably not right. > > Well ideally you'd have some generic API doing it rather than > these omap specifc exported functions. > > Meanwhile, I guess you need to find some suitable location > for the header file that works for Rafael. I wonder if including mach/voltage.h is acceptable here? if Kevin could suggest an option as well, it will be great.
-- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
