Hi Jon, On Fri, Nov 16, 2012 at 6:12 PM, Jon Hunter <[email protected]> wrote: > > diff --git a/arch/arm/mach-omap2/clock33xx_data.c > > b/arch/arm/mach-omap2/clock33xx_data.c > > index b7b7995..d0b4313 100644 > > --- a/arch/arm/mach-omap2/clock33xx_data.c > > +++ b/arch/arm/mach-omap2/clock33xx_data.c > > @@ -585,6 +585,7 @@ static struct clk debugss_ick = { > > .clkdm_name = "l3_aon_clkdm", > > .parent = &dpll_core_m4_ck, > > .ops = &clkops_omap2_dflt, > > + .flags = ENABLE_ON_INIT, > > .enable_reg = AM33XX_CM_WKUP_DEBUGSS_CLKCTRL, > > .enable_bit = AM33XX_MODULEMODE_SWCTRL, > > .recalc = &followparent_recalc, > > Does this mean this clock will always be enabled, even when not using > JTAG? If so, is that what you want?
Yes, the clock will always be on, because some times we connect JTAG on a running Linux system without powering it down. I can't comment without doing measurements if keeping the clock on has significant impact on power, but I see what you mean. Definitely low power is a parameter and folks who want lowest possible power might need to turn off the clock and not have JTAG in production, but that depends on the user's requirement. I personally don't care about power as much as I care about not being able to JTAG, and I think there are other folks who suffer from the same JTAG problem who wouldn't necessarily want lowest power. > I was not sure if you are concerned about power at all. Or if having > that always enabled can inhibit low power states for suspend/idle etc. Maybe, suspend/resume code can turn off clock on suspend and enable it on resume. > May be worth adding more details to the changelog about if there are > side-effects to this change or not. Sure, will do after waiting for any other review comments. Thanks, Joel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
