On Fri, Mar 15, 2013 at 1:37 PM, Laurent Pinchart <[email protected]> wrote: > Hi Fabio, > > Thank you for the patch. > > On Friday 15 March 2013 10:00:19 Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda <[email protected]> >> Cc: Florian Tobias Schandinat <[email protected]> >> Cc: Nicolas Ferre <[email protected]> >> Cc: Tomi Valkeinen <[email protected]> >> Cc: David Howells <[email protected]> >> Cc: Geert Uytterhoeven <[email protected]> >> Cc: Laurent Pinchart <[email protected]> >> Cc: Kuninori Morimoto <[email protected]> >> --- >> >> Notes: >> v3: >> - add missing drivers: amifb, atmel_lcdfb, vrfb >> - split patch set to each maintainer to easy up respin >> v2: >> - rebased over linux-next and remove already converted drivers >> >> drivers/video/amifb.c | 14 +------------- >> drivers/video/atmel_lcdfb.c | 13 +------------ >> drivers/video/omap2/vrfb.c | 13 +------------ >> drivers/video/sh_mipi_dsi.c | 12 +----------- >> drivers/video/sh_mobile_hdmi.c | 12 +----------- >> 5 files changed, 5 insertions(+), 59 deletions(-) >> >> diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c >> index 7fa1bf8..03e2de2 100644 >> --- a/drivers/video/amifb.c >> +++ b/drivers/video/amifb.c >> @@ -3788,19 +3788,7 @@ static struct platform_driver amifb_driver = { >> }, >> }; >> >> -static int __init amifb_init(void) >> -{ >> - return platform_driver_probe(&amifb_driver, amifb_probe); >> -} >> - >> -module_init(amifb_init); >> - >> -static void __exit amifb_exit(void) >> -{ >> - platform_driver_unregister(&amifb_driver); >> -} >> - >> -module_exit(amifb_exit); >> +return module_platform_driver_probe(amifb_driver, amifb_probe); > > I think think you need a "return" here. > > After fixing that,
Thanks for reviewing. I will send shortly the patch v4. Regards Fabio Porcedda > Acked-by: Laurent Pinchart <[email protected]> > >> MODULE_LICENSE("GPL"); >> MODULE_ALIAS("platform:amiga-video"); > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
