Hi Pekon, On Sun, 2013-06-23 at 23:28 +0530, Pekon Gupta wrote: > +---------------------------------------+---------------+---------------+ > | ECC scheme |ECC calculation|Error detection| > +---------------------------------------+---------------+---------------+ > |OMAP_ECC_HAMMING_CODE_DEFAULT |S/W |S/W > | > |OMAP_ECC_HAMMING_CODE_HW |H/W (GPMC) |S/W | > |OMAP_ECC_HAMMING_CODE_HW_ROMCODE |H/W (GPMC) |S/W | > +---------------------------------------+---------------+---------------+ > |(requires CONFIG_MTD_NAND_ECC_BCH) | | | > |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W | > +---------------------------------------+---------------+---------------+ > |(requires CONFIG_MTD_NAND_OMAP_BCH) | | | > |OMAP_ECC_BCH8_CODE_HW |H/W (GPMC) |H/W (ELM) > | > +---------------------------------------+---------------+---------------+
This is a nice table, and you are doing very good job clearly classifying what is going on. I'd suggest to also put stuff like this to comments in the code. > This patch > - separates the configurations for various ECC schemes. > - fixes dependency issues based on Kconfig options. > - cleans up redundant code > > Signed-off-by: Pekon Gupta <[email protected]> This does not apply to l2-mtd.git, could you please re-base? -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
