On 7/20/2013 6:02 AM, David Miller wrote: > From: Mugunthan V N <[email protected]> > Date: Fri, 19 Jul 2013 19:37:21 +0530 > >> Add support to show CPSW hardware statistics to user via ethtool get_regs >> ops so user can find if there were any error reported or the system is >> over loaded duing hagh data rate transfer. >> >> Signed-off-by: Mugunthan V N <[email protected]> > This is not the correct way to provide this functionality. ->get_regs() > is for dumping the raw hardware registers to userspace for low level > debugging purposes, not for providing HW specific statistics. > > The correct thing to do is provide an appropriate implementation of > the ->get_strings() and ->get_ethtool_stats() methods. Will change the implementation and resubmit the patch.
Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
