On 7/22/2013 10:35 PM, Ben Hutchings wrote: > On Mon, 2013-07-22 at 14:07 +0530, Mugunthan V N wrote: >> Add support to show CPSW hardware statistics to user via ethtool >> so user can find if there were any error reported by hardware or >> the system is over loaded duing high data rate transfer. >> >> Signed-off-by: Mugunthan V N <[email protected]> >> --- >> drivers/net/ethernet/ti/cpsw.c | 202 >> ++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 200 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c >> index 05a1674..f344c05 100644 >> --- a/drivers/net/ethernet/ti/cpsw.c >> +++ b/drivers/net/ethernet/ti/cpsw.c > [...] >> +static const struct cpsw_stats cpsw_gstrings_stats[] = { >> + { "Good Rx Frames", CPSW_STAT(rxgoodframes) }, >> + { "Broadcast Rx Frames", CPSW_STAT(rxbroadcastframes) }, >> + { "Multicast Rx Frames", CPSW_STAT(rxmulticastframes) }, >> + { "Pause Rx Frames", CPSW_STAT(rxpauseframes) }, >> + { "Rx CRC Errors", CPSW_STAT(rxcrcerrors) }, > [...] > > Statistic names usually don't contain spaces, though I can accept this > is probably more readable. > >> +static void cpsw_get_ethtool_stats(struct net_device *ndev, >> + struct ethtool_stats *stats, u64 *data) >> +{ >> + struct cpsw_priv *priv = netdev_priv(ndev); >> + struct cpdma_chan_stats rx_stats; >> + struct cpdma_chan_stats tx_stats; >> + u32 val; >> + u8 *p; >> + int i; >> + >> + /* Collect Davinci CPDMA stats for Rx and Tx Channel */ >> + cpdma_chan_get_stats(priv->rxch, &rx_stats); >> + cpdma_chan_get_stats(priv->txch, &tx_stats); >> + >> + for (i = 0; i < CPSW_STATS_LEN; i++) { >> + switch (cpsw_gstrings_stats[i].type) { >> + case CPSW_STATS: >> + val = readl((u8 *)priv->hw_stats + > Shouldn't this cast use 'u8 __iomem *'? Yes, will change this in v2 and submit it.
Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
