On 08/22/2013 03:14 PM, Tony Lindgren wrote: > * Chen Gang <[email protected]> [130821 01:34]: >> Need add type cast, or can not notice the failure. The related warning >> (allmodconfig, "EXTRA_CFLAGS=-W"): >> >> arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned >> expression < 0 is always false [-Wtype-limits] >> >> >> Signed-off-by: Chen Gang <[email protected]> >> --- >> arch/arm/mach-omap2/gpmc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c >> index f3fdd6a..62377b5 100644 >> --- a/arch/arm/mach-omap2/gpmc.c >> +++ b/arch/arm/mach-omap2/gpmc.c >> @@ -725,7 +725,7 @@ static int gpmc_setup_irq(void) >> return -EINVAL; >> >> gpmc_irq_start = irq_alloc_descs(-1, 0, GPMC_NR_IRQ, 0); >> - if (gpmc_irq_start < 0) { >> + if ((signed)gpmc_irq_start < 0) { >> pr_err("irq_alloc_descs failed\n"); >> return gpmc_irq_start; >> } > > Hmm shouldn't we just have int gpmc_irq_start instead > of unsigned gpmc_irq_start? >
Oh, thanks, that sounds reasonable to me, I will send patch v2. > Regards, > > Tony > > Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
