Hi Linus, On Thu, 5 Sep 2013, Linus Walleij wrote:
> Atleast eight bytes of this number are totally unique for the device > it seems, so this is a perfect candidate for feeding the entropy > pool. One byte more or less of constants does not matter so feed in > the entire OID struct. > > Cc: Theodore Ts'o <[email protected]> > Cc: Paul Walmsley <[email protected]> > Reviewed-by: Kevin Hilman <[email protected]> > Signed-off-by: Linus Walleij <[email protected]> Heh, that function name "add_device_randomness()" is a bit misleading. It's not actually intended to add "randomness": from drivers/char/random.c: /* * Add device- or boot-specific data to the input and nonblocking * pools to help initialize them to unique values. * * None of this adds any entropy, it is meant to avoid the * problem of the nonblocking pool having similar initial state * across largely identical devices. */ But of course the function name is not your fault :-) The entropy count isn't increased by this, so: Reviewed-by: Paul Walmsley <[email protected]> Thanks Linus. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
