On 26/09/13 13:12, Mark Brown wrote: > On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote: > >> I wish we could "select" instead of "depends on"... > > We probably could.
I'm not so sure. If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling backlight.c without fbdev, and backlight.c uses fb's funcs. The funny thing is, there is FB_BACKLIGHT, which seems to be designed to be selectable (and is selected). That one depends on FB, but if I'm not mistaken, that dependency does not do anything if FB_BACKLIGHT is selected. FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be selectable. I think that's a bit broken. Anyway, I guess it's better to "depend on" here, to be on the safe side. Tomi
signature.asc
Description: OpenPGP digital signature
