On Thu, Oct 10, 2013 at 07:36:33AM +0100, Archit Taneja wrote: > Add Dynamic Memory Manager (DMM) bindings for OMAP4 and OMAP5 devices. DMM > only requires address and irq information. > > Add documentation for the DMM bindings. > > Originally worked on by Andy Gross <andy...@gmail.com> > > Cc: Andy Gross <andy...@gmail.com> > Signed-off-by: Archit Taneja <arc...@ti.com> > --- > Documentation/devicetree/bindings/arm/omap/dmm.txt | 16 ++++++++++++++++ > arch/arm/boot/dts/omap4.dtsi | 7 +++++++ > arch/arm/boot/dts/omap5.dtsi | 7 +++++++ > 3 files changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/omap/dmm.txt > > diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt > b/Documentation/devicetree/bindings/arm/omap/dmm.txt > new file mode 100644 > index 0000000..6fc3d79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt > @@ -0,0 +1,16 @@ > +OMAP Dynamic Memory Manager (DMM) bindings
Is there any documentation? A brief description of what this is would be nice. > + > +Required properties: > +- compatible: Must be "ti,omap4-dmm" for OMAP4 family > + Must be "ti,omap5-dmm" for OMAP5 and DRA7x family s/must be/should contain/ > +- reg: Contains timer register address range (base address and > length) Huh? What's a timer got to do with the DMM? > +- interrupts: Contains interrupt information (source, etc) for the > DMM IRQ Is there a single interrupt? If so: - interrupts: Should contain an interrupt-specifier for the DMM IRQ. Assuming the "DMM IRQ" is well defined. If there's a name for it in documentation, using that's preferable. If a future revision may have multiple interrupts, please use interrupt-names now to save us endless pain in future. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
