> > I'd also include dev_err, dev_warn and dev_info :) > > What's their advantage?
They are a bit shorter and much more common AFAICT.
>
> > > if (csc & I365_CSC_DETECT) {
> > > events |= SS_DETECT;
> > > - dprintk("Card detected in socket %i!\n", i);
> > > + dev_dbg(&socket[i].socket.dev,
> > > + "Card detected in socket %i!\n", i);
> >
> > Dunno, in days of dynamic_printk it might be better to skip debug outputs
> > in ISRs, no?
>
> Why?
They may not be compiled out although they are not used. Dunno, maybe I'm a bit
biased because I often fight latencies ;)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
