Hey,

On Sun, Oct 25, 2009 at 11:22:31AM +0900, Komuro wrote:
> The pcmcia_do_get_mac has a bug,

Many thanks for reviewing my patches.


> tuple->TupleDataLen should be ETH_ALEN + 3;

Hmmm... ETH_ALEN is 6, both xirc2ps_cs.c and ssb/pcmcia.c checked for
TupleDataLen==8... Maybe this isn't as standardized as it should be. Might

> -     if (tuple->TupleDataLen != ETH_ALEN + 2)
> +     if (tuple->TupleDataLen < (ETH_ALEN + 2))

be more suitable?

Best,
        Dominik

_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Reply via email to