Sergei,
On Mon, Oct 26, 2009 at 06:47:49PM +0300, Sergei Shtylyov wrote:
> Dominik Brodowski wrote:
>
>> ide-cs.c is the only PCMCIA device driver making use of CONFIG_PCMCIA_DEBUG,
>> so convert it to use the dynamic debug infrastructure.
>
>> Also, remove all usages of the CS_CHECK macro and replace them with proper
>> Linux style calling and return value checking. The extra error reporting may
>> be dropped, as the PCMCIA core already complains about any
>> (non-driver-author)
>> errors.
>
>> CC: [email protected]
>> Signed-off-by: Dominik Brodowski <[email protected]>
>> ---
>> drivers/ata/pata_pcmcia.c | 16 ++++++++--------
>> drivers/ide/ide-cs.c | 32 +++++++++++---------------------
>> 2 files changed, 19 insertions(+), 29 deletions(-)
>
> Please submit as two separate patches as ide and libata are two
> separate subsystems.
thanks for your comment. And I see your point -- but as I intend to push this
upstream using the linux-pcmcia tree, as the IDE and ATA subsystems use the
same (linux-ide) mailing list, and as both drivers are quire related, I
thought handling both drivers in one patch is acceptable. If it still needs
to be done otherwise, I'll re-submit this patch in two parts and udpate my
workflow accordingly.
Best,
Dominik
_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
