On Mon, Apr 12, 2010 at 07:49:15PM +0400, Alexander Kurz wrote: > Hello folks, > this is an attempt, to reanimate the pcmciamtd driver.
Nice :)
> @@ -652,7 +651,6 @@ static int pcmciamtd_config(struct pcmcia_device *link)
> link->dev_node = &dev->node;
> return 0;
>
> - failed:
> err("CS Error, exiting");
> pcmciamtd_release(link);
> return -ENODEV;
I'd suggest keeping 'failed', removing the 'err'-statement and using 'goto
failed' in error cases. Currently, pcmciamtd_release() is used many times on
errors.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
