On 09/02/2011 02:02 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 02, 2011 at 01:41:51PM -0600, David Ahern escreveu:
>> @@ -423,18 +449,25 @@ int perf_event__parse_sample(const union perf_event
>> *event, u64 type,
>> }
>>
>> if (type & PERF_SAMPLE_RAW) {
>> - u32 *p = (u32 *)array;
>> + u.val64 = *array;
>> + if (swapped) {
>> + /* undo swap of u64, then swap on individual u32s */
>> + u.val64 = bswap_64(u.val64);
>> + u.val32[0] = bswap_32(u.val32[0]);
>> + u.val32[1] = bswap_32(u.val32[1]);
>> +
>> + WARN_ONCE(swapped, "Endianness of raw data not
>> corrected!\n");
>> + }
>
> That works too, but then we'll be always testing swapped two times :-)
>
> - Arnaldo
I did not see a WARN_ONCE with no 'condition' variable, so I went with
the redundant test. I guess swapped really could be changed to '1' --
like an example I saw in the acpi code.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
