On Mon, Dec 07, 2015 at 07:53:14PM +0100, Michael Petlan wrote:

SNIP

> +
> +     ../common/check_all_patterns_found.pl "PERF-ANNOTATE" "NAME" "SYNOPSIS" 
> "DESCRIPTION" "OPTIONS" "SEE ALSO" < basic_helpmsg.log
> +     CHECK_EXIT_CODE=$?
> +     ../common/check_all_patterns_found.pl "perf\-annotate \- Read perf.data 
> .* display annotated code" < basic_helpmsg.log
> +     (( CHECK_EXIT_CODE += $? ))
> +     ../common/check_all_patterns_found.pl "input" "dsos" "symbol" "force" 
> "verbose" "dump-raw-trace" "vmlinux" "modules" < basic_helpmsg.log
> +     (( CHECK_EXIT_CODE += $? ))
> +     ../common/check_all_patterns_found.pl "print-line" "full-paths" "stdio" 
> "tui" "cpu" "source" "symfs" "disassembler-style" < basic_helpmsg.log
> +     (( CHECK_EXIT_CODE += $? ))
> +     ../common/check_all_patterns_found.pl "objdump" "skip-missing" "group" 
> < basic_helpmsg.log
> +     (( CHECK_EXIT_CODE += $? ))

I know it's probably PITA, but would it make sense to preceed
each line with the actuall line you are expecting? like:

        ###
        #  perf-annotate - Read perf.data (created by perf record) and display 
annotated code
        #
        ../common/check_all_patterns_found.pl "perf\-annotate \- Read perf.data 
.* display annotated code" < basic_helpmsg.log
        (( CHECK_EXIT_CODE += $? ))

        ###
        #   Disassembly of section load0:
        #       │    Disassembly of section load0:
        # 16.67 │      xor    %eax,%eax
        # 
        ../common/check_all_patterns_found.pl "$REGEX_HEADER load" 
"$REGEX_LINE" "$REGEX_SECTION__TEXT" < basic_annotate.log
        CHECK_EXIT_CODE=$?

        ###
        # from = atol (argv[1]);
        # 
        ../common/check_all_patterns_found.pl "main" "from = atol" "from = 
20L;" "for\s*\(i = 1L; j; \+\+i\)" "return 0;" < basic_annotate.log
        (( CHECK_EXIT_CODE += $? ))


or some other way that would make it easy to find out what
the check is looking for in general

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to