From: WANG Cong <>

3.12-stable review patch.  If anyone has any objections, please let me know.


commit 205e1e255c479f3fd77446415706463b282f94e4 upstream.

Matt reported that we have a NULL pointer dereference
in ppp_pernet() from ppp_connect_channel(),
i.e. pch->chan_net is NULL.

This is due to that a parallel ppp_unregister_channel()
could happen while we are in ppp_connect_channel(), during
which pch->chan_net set to NULL. Since we need a reference
to net per channel, it makes sense to sync the refcnt
with the life time of the channel, therefore we should
release this reference when we destroy it.

Fixes: 1f461dcdd296 ("ppp: take reference on channels netns")
Reported-by: Matt Bennett <>
Cc: Paul Mackerras <>
Cc: Guillaume Nault <>
Cc: Cyrill Gorcunov <>
Signed-off-by: Cong Wang <>
Reviewed-by: Cyrill Gorcunov <>
Signed-off-by: David S. Miller <>
Signed-off-by: Jiri Slaby <>
 drivers/net/ppp/ppp_generic.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 14a8d2958698..ab79c0f13d0a 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -2317,8 +2317,6 @@ ppp_unregister_channel(struct ppp_channel *chan)
-       put_net(pch->chan_net);
-       pch->chan_net = NULL;
        pch->file.dead = 1;
@@ -2925,6 +2923,9 @@ ppp_disconnect_channel(struct channel *pch)
 static void ppp_destroy_channel(struct channel *pch)
+       put_net(pch->chan_net);
+       pch->chan_net = NULL;
        if (!pch->file.dead) {

To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to
More majordomo info at

Reply via email to